Merged
Conversation
Base automatically changed from
dev/seldridge/use-builder-exceptions-in-properties
to
main
March 20, 2026 22:00
Add a new API for creating variadic `string_concat` FIRRTL operations. This is useful for working with string properties and specifically for setting the name of domains which are derived from other domains. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/string_concat
branch
from
95d3a15 to
503f39b
Compare
jackkoenig
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new API for creating variadic
string_concatFIRRTL operations.This is useful for working with string properties and specifically for
setting the name of domains which are derived from other domains.
AI-assisted-by: Augment (Sonnet 4.5)
Release Notes
Add new
Property.concatoperation that can be used to (currently) justconcatenate strings. This is useful for building up properties from smaller
strings. This maps to the
string_concatFIRRTL operation.