Merged
Conversation
jackkoenig
added
the
Deprecation
It was already deprecated to use the converted FIRRTL IR, but users could avoid the deprecation message in some circumstances by using the phase directly.
jackkoenig
force-pushed
the
jackkoenig/deprecate-convert-phase
branch
from
abdf322 to
13dd411
Compare
seldridge
approved these changes
Apr 3, 2026
seldridge
reviewed
Apr 3, 2026
| "cat=deprecation&origin=chisel3\\.experimental\\.IntrinsicModule:s", | ||
| "cat=deprecation&origin=chisel3\\.ltl.*:s", | ||
| "cat=deprecation&origin=chisel3\\.InstanceId:s", | ||
| "cat=deprecation&origin=chisel3\\.stage\\.phases\\.Convert:s", |
Member
There was a problem hiding this comment.
Instead of allowing the deprecation, could we remove the usages of this?
Contributor
Author
There was a problem hiding this comment.
It would be a functional change, I think we should just do it when we start on 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was already deprecated to use the converted FIRRTL IR, but users could avoid the deprecation message in some circumstances by using the phase directly.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Use ElaboratedCircuit instead.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.