Ion stage 1#60
Merged
Merged
Conversation
Feature/cleanup
…cluded new truffle version in package.json.
First half of CLI
…to update_readme
Update readme and package.json
Updated README
…sing characters from README.
Removed all helper scripts now that commands are in README. Added mis…
Updated README. Modified contracts to follow Solidity coding style.
Feature/requirements versioning
…moved some redundant files. Improved example.sh script. Other minor changes.
CLI now uses specified lithium api ports to form merkle paths etc. Re…
Removed duplicate lithium segment. Fixed typos and newlines.
Improved tutorial
Fixed the difference between the tutorial and example.sh and fixed th…
fixed ports
Example ports
Added wiki link to README
Removed .idea file
Updated gitignore to ignore .idea directory
Shirikatsu
requested review from
AntoineRondelet,
IronGauntlets,
daragao,
maxrobot,
rmsams,
shapeshed,
yazzaoui and
zoenolan
May 8, 2018 15:47
maxrobot
approved these changes
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging our working Ion Stage 1 PoC to master. Still lots of work and enhancements to be made but current happy path is working as intended.