Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

Add annotation response status#188

Closed
llbrt wants to merge 124 commits intocloudendpoints:masterfrom
AODocs:add_annotation_response_status
Closed

Add annotation response status#188
llbrt wants to merge 124 commits intocloudendpoints:masterfrom
AODocs:add_annotation_response_status

Conversation

@llbrt
Copy link

@llbrt llbrt commented Jun 11, 2020

This change is Reviewable

Clément Denis and others added 30 commits March 1, 2019 19:50
- param and resource de/serialization uses Jackson configuration
- schema generation used Enum.name(), should use Jackson instead
- may enhance ServiceException with extra fields
- limit values to simple objects (nor array nor collection)
- add extra fields in error body
- add unit tests
- note: add test dependency to JSONassert, license Apache 2.0
Fix inconsistent enum constant names between schema and serialization
Use TreeMaps in SwaggerGenerator to ensure stable openapi.json output
- fixes multiple CVEs
- force base64 variant MIME_NO_LINEFEEDS on ServletRequestParamReader
- updates lots of very outdated deps
- Requires minor adjustments to generator for comparison
Replace API explorer with developers.google.com
…elds

May add extra fields in ServiceException
- change groupId of the artifacts
- ignore test-compat during build: the tests fails because
  the switch to the new gradle plugin is required
  (com.google.cloud.tools:appengine-gradle-plugin)
  but this change is complex
Switch to altirnao project management
- adds a method in ServiceException to put an extra field
  value that may be unsafe (array, List, Map, ...)
- adds a unit test
May put any kind of extra field value
- Released 2.2.1 to aodocs.jfrog.io
- Change version to 2.2.2
Use standard object writer for errors
Use setHeader for X-Frame-Options in ApiProxyHandler to avoid conflict
Include the package 'com.google.thirdparty' in the list of packages to relocate.
- Strip out all information about internal implementation in the error message.
…alid_json

Use proper ServiceException when impossible to parse json input.
RaHery and others added 26 commits November 4, 2019 14:47
Update dependencies and remove deprecations
… by default)

- Allow "custom" ConfiguredObjectMapper
- Add many test cases for Strings in containers
- Enable support for java.util.Optional (jackson-datatype-jdk8)
- Enable support for parameter names for constructor detection on deserialization (jackson-module-parameter-names)
Improve Java 8 support in (de)serialization
Fix handling of empty strings in maps (should be included in response by default)
- add actions to create API client source code
  locally when the Google API client code
  generator is installed (command generate_library)
- add python and the code generator for
  the unit test of the API client code
  generation
Tools: adds actions to create client code
- Ignore test when the tool is not installed (instead of
  making it successful)
- Add new values in discovery file to fix package names
- add the annotation value responseStatus in ApiMethod
  to define a custom response status (other than 200
  204 if there is no content)
- add unit tests
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #188 into master will increase coverage by 2.45%.
The diff coverage is 90.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     80.06%   82.51%   +2.45%     
- Complexity     1715     1850     +135     
============================================
  Files           159      161       +2     
  Lines          5718     6710     +992     
  Branches        754      883     +129     
============================================
+ Hits           4578     5537     +959     
- Misses          856      859       +3     
- Partials        284      314      +30     
Impacted Files Coverage Δ Complexity Δ
...le/api/server/spi/auth/EndpointsAuthenticator.java 94.11% <0.00%> (-5.89%) 6.00 <0.00> (ø)
...va/com/google/api/server/spi/config/ApiMethod.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/com/google/api/server/spi/config/Singleton.java 78.94% <ø> (+2.47%) 0.00 <0.00> (ø)
...er/spi/config/annotationreader/AnnotationUtil.java 83.33% <ø> (+9.42%) 17.00 <0.00> (-2.00) ⬆️
...i/config/annotationreader/ApiAnnotationConfig.java 90.80% <ø> (+0.10%) 48.00 <0.00> (-2.00) ⬆️
...fig/annotationreader/ApiClassAnnotationConfig.java 82.35% <ø> (-1.44%) 18.00 <0.00> (-2.00)
...fig/jsonwriter/AbstractResourceSchemaProvider.java 90.00% <ø> (+2.50%) 4.00 <0.00> (ø)
...le/api/server/spi/config/model/ApiClassConfig.java 67.64% <0.00%> (-5.76%) 29.00 <0.00> (-1.00)
.../google/api/server/spi/config/model/ApiConfig.java 94.94% <0.00%> (+0.33%) 67.00 <0.00> (-2.00) ⬆️
...com/google/api/server/spi/config/model/Schema.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b7374...d7f6535. Read the comment docs.

@llbrt llbrt closed this Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants