Skip to content

Enable @typescript-eslint/no-deprecated linting rule for edge-preview-authenticated-proxy package#14509

Merged
dario-piotrowicz merged 1 commit into
mainfrom
dario/no-deprecated-edge-preview-authenticated-proxy
Jul 3, 2026
Merged

Enable @typescript-eslint/no-deprecated linting rule for edge-preview-authenticated-proxy package#14509
dario-piotrowicz merged 1 commit into
mainfrom
dario/no-deprecated-edge-preview-authenticated-proxy

Conversation

@dario-piotrowicz

@dario-piotrowicz dario-piotrowicz commented Jul 1, 2026

Copy link
Copy Markdown
Member

This PR enabled the @typescript-eslint/no-deprecated linting rule for edge-preview-authenticated-proxy package

Followup for #14472, #14491 and #14522


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b1c6723

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod
workers-devprod requested review from a team and emily-shen and removed request for a team July 1, 2026 15:20
@workers-devprod

workers-devprod commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14509

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14509

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14509

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14509

miniflare

npm i https://pkg.pr.new/miniflare@14509

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14509

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14509

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14509

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14509

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14509

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14509

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14509

wrangler

npm i https://pkg.pr.new/wrangler@14509

commit: b1c6723

@ask-bonk

ask-bonk Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The prior PRs didn't touch the SELFexports.default migration in this specific way, so this is the first application to this package.

I've done thorough analysis. Let me summarize my assessment:

  1. The core migration is correct: SELF from cloudflare:test is genuinely @deprecated (line 11-13 of cloudflare-test.d.ts) with the exact recommended replacement being import { exports } from "cloudflare:workers" + exports.default.fetch(). The change matches the deprecation guidance precisely.

  2. worker-configuration.d.ts regeneration is correct: it adds the Cloudflare.GlobalProps.mainModule typing needed for exports.default, and preserves all env vars.

  3. Behavioral equivalence: The mock at lines 21-24 handles the waitUntil logging fetch, so no behavior regression.

  4. The one thing I flaggedtests/tsconfig.json includes a non-existent ../src/env.d.ts and doesn't include worker-configuration.d.ts — is a pre-existing condition not introduced by this PR (the tsconfig is unchanged in the diff). It's not this PR's responsibility, and since the type-check evidently resolves exports.default through the pool types, it's not a regression introduced here.

The changes are clean, correct, and match the deprecation guidance and precedent. The tsconfig observation is pre-existing and out of scope. No actionable issues introduced by this PR.

LGTM

github run

@dario-piotrowicz dario-piotrowicz added the ci:no-changeset-required Skip pull request checks for a valid changeset label Jul 1, 2026
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/no-deprecated-edge-preview-authenticated-proxy branch 3 times, most recently from 1af5aab to 0e3dde2 Compare July 1, 2026 18:31
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/no-deprecated-edge-preview-authenticated-proxy branch from 0e3dde2 to b1c6723 Compare July 1, 2026 18:34
Comment thread packages/edge-preview-authenticated-proxy/tests/tsconfig.json
@dario-piotrowicz
dario-piotrowicz requested a review from NuroDev July 3, 2026 14:18

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jul 3, 2026
@dario-piotrowicz
dario-piotrowicz merged commit 0118db0 into main Jul 3, 2026
79 checks passed
@dario-piotrowicz
dario-piotrowicz deleted the dario/no-deprecated-edge-preview-authenticated-proxy branch July 3, 2026 16:48
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants