Enable @typescript-eslint/no-deprecated linting rule for vite-plugin-cloudflare

[dario-piotrowicz]

This PR enables the @typescript-eslint/no-deprecated linting rule for the vite-pluging-cloudflare package

Followup for #14472, #14491, #14509, #14522, #14579, #14625 and #14671

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: internal refactoring

[ask-bonk]

The changes are consistent and correct. Let me do a final verification on the fallbackOptions type — the object has logLevel: "silent" as const, but I want to confirm both rolldownOptions and rollupOptions accept this shape. The output.entryFileNames and input are common. logLevel — let me verify this is valid for both. This was "silent" before as rollupOptions.logLevel, so it's valid for rollup. For rolldown, RolldownOptions should also support logLevel. Given the as const was needed, TypeScript is validating this against both branches. Since the PR presumably passed pnpm check (type-check under Vite 8), and the code assigns fallbackOptions to both rolldownOptions and rollupOptions, TS would flag a mismatch if incompatible.

There's one subtle issue worth flagging: fallbackOptions is now a shared object literal assigned to environment.config.build.rolldownOptions OR rollupOptions. Under Vite 6/7, rolldownOptions doesn't exist, but that branch is guarded by isRolldown, so it's never executed there. Fine at runtime.

I've thoroughly reviewed all four changed files. The changes:

1. Remove the lint override (correct, the goal of the PR)
2. build.ts — branch rollup/rolldown for reading and writing build input options, correctly guarded by isRolldown, with no-deprecated disable comments only on the genuinely-deprecated rollupOptions accesses
3. cloudflare-environment.ts — remove deprecated Rollup.RollupOptions annotation, use as const
4. vitest-setup.ts — swap deprecated Rollup.* types for Rolldown.* (type-only, runtime-safe)

The logic is consistent between the read (hasClientEntry) and write (fallbackBuild) sites, the guards match the existing pattern in cloudflare-environment.ts, and no behavioral regression is introduced. Type-checking runs under Vite 8 where the Rolldown namespace exists; Vite 6/7 CI only runs runtime playground tests where erased types have no effect.

No actionable issues found.

LGTM

github run

[pkg-pr-new]

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14718

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14718

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14718

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14718

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14718

miniflare

npm i https://pkg.pr.new/miniflare@14718

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14718

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14718

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14718

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14718

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14718

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14718

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14718

wrangler

npm i https://pkg.pr.new/wrangler@14718

commit: 450ec7b

[changeset-bot]

⚠️ No Changeset found

Latest commit: 450ec7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[workers-devprod]

Codeowners reviews satisfied