Enable @typescript-eslint/no-deprecated linting rule for local-explorer-ui#14625
Merged
Conversation
|
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
July 9, 2026 11:46
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
added
the
ci:no-changeset-required
NuroDev
requested changes
Jul 9, 2026
Contributor
|
@dario-piotrowicz Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
dario-piotrowicz
commented
Jul 9, 2026
NuroDev
approved these changes
Jul 10, 2026
workers-devprod
approved these changes
Jul 10, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Replace the deprecated `JSX` namespace with the proper `React.JSX` one (see: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/113349c5/types/react/v18/index.d.ts#L4347)
Replace the deprecated `React.FormEvent` type with `React.SyntheticEvent` (see: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/1c32774e/types/react/index.d.ts#L2077-L2081)
Remove the setting of the `e.returnValue` value since it is deprecated and it doesn't/shouldn't have an effect on modern browsers (see: https://developer.mozilla.org/en-US/docs/Web/API/BeforeUnloadEvent/returnValue)
dario-piotrowicz
force-pushed
the
dario/no-deprecated-local-explorer-ui
branch
from
July 10, 2026 09:57
833b3db to
1981c55
Compare
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enabled the
@typescript-eslint/no-deprecatedlinting rule for thelocal-explorer-uipackageFollowup for #14472, #14491, #14509, #14522 and #14579