Restore service instance dashboard link (#5490) - #5491
Merged
norman-abramovitz merged 2 commits intoJun 24, 2026
Merged
Conversation
The signal-list migration dropped the Dashboard link the old service-instance lists showed (v4.9.3 had it on the services-wall card and a shared Dashboard table column). The new signal-list link kind only does internal routerLink, so an external dashboard_url could not be re-added as-is. - signal-list: add an optional externalLink accessor; when set, the table and card cells render a launch icon + text as <a href target="_blank" rel="noopener">. Internal-link behavior is unchanged; the row click-through is unaffected (rowLink still only follows kind:'link' + link). - shared dashboard-link-cell helper: "View" link to dashboardUrl, or "None" when absent (UPS / brokers that set no dashboard_url). - add a Dashboard column to the four managed service-instance lists: services wall, CF services tab, space service instances, offering instances. dashboardUrl already arrives at the return=summary tier these lists load, so no backend change is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5490
The dashboard hyperlink the old Stratos showed on service instances was lost in the signal-list migration. v4.9.3 rendered it two ways — the services-wall card and a shared Dashboard table column — and both went away when each list's columns were rebuilt. The new signal-list
linkcolumn only does internal routerLink, so an externaldashboard_urlcouldn't be re-added as-is.This adds an optional
externalLinkaccessor to the signal-list column: when set, the table and card cells render a launch icon + text as<a href target="_blank" rel="noopener">, leaving internal-link behaviour unchanged. A shared dashboard-link cell maps it to "View" (or "None" when the broker advertises nodashboard_url), and the Dashboard column is restored on the four managed service-instance lists: services wall, CF services tab, space service instances, and offering instances.dashboard_urlalready arrives at thereturn=summarytier these lists load, so there's no backend change.Verified against an example-service instance on a fixture broker: a managed instance shows the launch + View link to its dashboard URL; user-provided and managed-without-dashboard instances show None.