fix(core): rework the shared-URL banner sentence for accuracy - #5698
Merged
norman-abramovitz merged 1 commit intoJul 26, 2026
Merged
Conversation
Three related inaccuracies, all found live against fw-lab-norm's real
duplicate registrations (cf1-4 on api.sys.adepttech.ca, fw-lab-norm-1..4
on a different CF url, plus 4 kind-korifi variants on one k8s url):
1. Multiple types were joined into one shared-verb sentence: '8 Cloud
Foundry endpoints and 4 Kubernetes endpoints share URLs.' reads as a
joint action between the two groups, as if a CF endpoint and a k8s
endpoint could share a URL with each other - they never do (duplicate
detection is strictly within a type). Each type is now its own
independent clause, semicolon-joined.
2. A single type can have more than one disjoint duplicate-URL group -
e.g. 4 endpoints on one URL, 4 different endpoints on a second,
unrelated URL. Summing them ('8 endpoints across 2 URLs') still
invites a false assumption that the groups are roughly equal-sized;
with uneven sizes (2, 4, 5) 'across 3 URLs' doesn't tell you the shape
at all. The message now leads with the URL count and lists every
group's actual size: '3 Cloud Foundry URLs are shared by 11 endpoints
(2, 4, and 5 per URL).' Repeated sizes (e.g. 3, 3, 5) are listed
plainly, not deduped.
3. The single- and multi-group phrasing were structurally inconsistent
(endpoints as subject vs. URLs as subject). Both now lead with the
URL(s): 'A Cloud Foundry URL is shared by 4 endpoints.' vs '3 Cloud
Foundry URLs are shared by 11 endpoints (2, 4, and 5 per URL).'
Combined real-world example: '2 Cloud Foundry URLs are shared by 8
endpoints (4 and 4 per URL); A Kubernetes URL is shared by 4 endpoints.'
duplicateUrlStats now returns each group's size directly (sizes: number[])
instead of just a group count, so formatDuplicateUrlEndpointsMessage can
list them via Intl.ListFormat. Updated all existing tests that encoded
the old phrasing; added coverage for uneven and repeated group sizes.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"A Cloud Foundry URL is shared by 4 endpoints."vs"3 Cloud Foundry URLs are shared by 11 endpoints (2, 4, and 5 per URL)."Combined real-world example (fw-lab-norm's actual duplicate registrations — cf1-4 on one CF url, fw-lab-norm-1..4 on a different CF url, 4 kind-korifi variants on one k8s url):
duplicateUrlStatsnow returns each group's size directly (sizes: number[]) instead of just a group count, soformatDuplicateUrlEndpointsMessagecan list them viaIntl.ListFormat.Test plan
endpoint-utils.spec.ts,home-url-banner.component.spec.ts,duplicate-url-banner.component.spec.ts)eslintclean on all touched files