Extend duplicate-URL banner to k8s/helm + kubernetes picker parity - #5699
Merged
norman-abramovitz merged 2 commits intoJul 26, 2026
Conversation
Generalizes DuplicateUrlBannerComponent (moved cloud-foundry -> core, takes an `endpoints$` input instead of hardcoding CloudFoundryService) and wires it into the /workloads and /monocular/charts pages, scoped to their own connected endpoint type so neither page's banner leaks unrelated duplicates from another type. CF pages (Application Wall, Marketplace, Services, CF picker) now pass their endpoints$ explicitly instead of relying on the component's internal CF-only wiring; behavior unchanged.
Two gaps vs the CF picker: no duplicate-URL banner, and the kebab menu was deliberately suppressed (a legacy dsEndpointType: 'k8s' flag). Fixes both, plus brings the address/status rendering and row-action set (Connect/Disconnect/Reconnect/Edit, no Unregister - that stays admin-only on /endpoints) to parity with the CF picker. Drops the custom <app-endpoint-card> cardTemplate entirely so both card and table mode render from the same SignalListColumn config the CF picker uses (Name/Address/Status/Actions) instead of two different rendering paths - this is what makes the address field (plain Host, no scheme/copy-icon/warning-badge) and the table-mode kebab (missing before) fall out for free instead of needing separate fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuplicateUrlBannerComponent(movedcloud-foundry→core, takes anendpoints$input) and wires it into/workloadsand/monocular/charts, each scoped to its own connected endpoint type so no page's banner leaks unrelated duplicates from another type. CF pages now passendpoints$explicitly; behavior unchanged there./kubernetespicker to parity with/cloud-foundry's: adds the duplicate-URL banner, restores the row-action kebab (Connect/Disconnect/Reconnect/Edit — Unregister stays admin-only on/endpoints) which was previously suppressed by a legacydsEndpointType: 'k8s'flag, and drops the custom<app-endpoint-card>card template so both card and table mode render from the same column config the CF picker uses (plain-Host address, dot status, kebab actions) instead of two different rendering paths.Builds on #5698 (shared-URL banner sentence rework) — this PR only adds new banner call sites and the kubernetes picker parity fix, no changes to the sentence-construction logic itself.
Test plan
tsc --noEmit— zero new errors (4268 baseline errors are pre-existing, in unrelatede2e/buildfiles)/applications,/marketplace,/services,/cloud-foundry,/home,/workloads,/monocular/charts,/kubernetes(card + table mode)