fix(zora): confine local image paths and reject non-https remotes - #1425
Open
SashaMIT wants to merge 1 commit into
Open
fix(zora): confine local image paths and reject non-https remotes#1425SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Agent-controlled Zora image fell through to fs.readFile for anything that was not ipfs:// or https://, including absolute paths and http:// URLs, before Pinata upload. Twin of flaunch coinbase#1424: cwd realpath confine + scheme guard.
🟡 Heimdall Review Status
|
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twin of #1424 (flaunch). Zora
generateZoraTokenUritreated anyimagethat was notipfs://orhttps://as a local file path andfs.readFiled it before Pinata upload. Absolute paths (e.g./etc/passwd) andhttp://URLs fell through that path.This PR:
process.cwd()viarealpathhttp://) instead of reading them as filesTest plan
npx jest --testPathPattern=zora/utils(2 passed)https:///ipfs://coin create still works; absolute local escape fails closedMade with Cursor