fix(python/ssh): confine upload/download local paths to cwd - #1427
Open
SashaMIT wants to merge 1 commit into
Open
fix(python/ssh): confine upload/download local paths to cwd#1427SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Resolve agent-supplied local_path under process cwd (realpath) before SFTP upload/download so prompt-injected paths cannot read or write arbitrary files.
🟡 Heimdall Review Status
|
3 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python
ssh_upload/ssh_downloaduse agent-controlledlocal_pathwith bareexists/open/makedirsand no cwd/realpath confine. A prompt-injected path can read arbitrary files into a remote host (upload) or write arbitrary local destinations (download).Same local-path class as TypeScript twitter #1426 / flaunch #1424 / zora #1425. Distinct from those PRs (Python SSH provider) and from #1347 (control-char schema only).
Fix
resolve_safe_local_path: expanduser + resolve underos.getcwd(), require realpath stays under that root, then upload/download only the confined path.Test plan
uv run pytest tests/action_providers/ssh/test_path_utils.py tests/action_providers/ssh/test_upload.py tests/action_providers/ssh/test_download.py(12/12)/etc/passwd/../fail closed before SFTPMade with Cursor