fix(twitter): confine uploadMedia paths to cwd - #1426
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Resolve agent-supplied filePath under process.cwd() (realpath) before v1.uploadMedia so prompt-injected paths cannot exfiltrate arbitrary files.
🟡 Heimdall Review Status
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
upload_mediapasses agent-controlledfilePathstraight tov1.uploadMediawith no cwd/realpath confine. A prompt-injected path (e.g.../../.env,/etc/passwd) can read arbitrary process-readable files and exfiltrate them via Twitter media upload.Same local-path class as flaunch #1424 / zora #1425, on the Twitter action provider.
Fix
resolveSafeLocalMediaPath: resolve underprocess.cwd(), require realpath stays under that root, then upload only the confined path.Test plan
npx jest src/action-providers/twitter/utils.test.ts src/action-providers/twitter/twitterActionProvider.test.ts(20/20)../and absolute outsides fail closed beforeuploadMediaMade with Cursor