Conversation
adeebshihadeh
added
PC
Contributor
|
TODO
|
adeebshihadeh
force-pushed
the
runcarla
branch
from
dc24430 to
8060b8e
Compare
This was
linked to
issues
Aug 17, 2020
pd0wm
reviewed
Sep 7, 2020
pd0wm
reviewed
Sep 7, 2020
selfdrive/controls/controlsd.py
Outdated
| self.events.add(EventName.fcw) | ||
| if self.sm['model'].frameDropPerc > 1: | ||
| self.events.add(EventName.modeldLagging) | ||
| #self.events.add(EventName.modeldLagging) |
Contributor
There was a problem hiding this comment.
This needs to be gated between an environment variable. Maybe SIMULATION=1
Contributor
There was a problem hiding this comment.
hmm, this should run fast enough with the keras runner
pd0wm
reviewed
Sep 7, 2020
pd0wm
reviewed
Sep 7, 2020
pd0wm
reviewed
Sep 7, 2020
tools/sim/bridge.py
Outdated
| pm = messaging.PubMaster(['gpsLocationExternal']) | ||
| while 1: | ||
| dat = messaging.new_message('gpsLocationExternal') | ||
| if dat is not None: |
pd0wm
reviewed
Sep 7, 2020
tools/sim/bridge.py
Outdated
| pm.send('driverState', dat) | ||
| time.sleep(0.1) | ||
|
|
||
| # dmonotirongd output |
pd0wm
reviewed
Sep 7, 2020
pd0wm
reviewed
Sep 7, 2020
tools/sim/start_carla.sh
Outdated
| cd ../ | ||
| mv carla_tmp carla | ||
| fi | ||
| # Requires nvidia docker - https://github.com/NVIDIA/nvidia-docker |
Contributor
There was a problem hiding this comment.
Find a good check if nvidia-docker is installed. Maybe something with apt?
Contributor
There was a problem hiding this comment.
It’s commented out below this line
Contributor
There was a problem hiding this comment.
yeah, the which nvidia-docker check doesn't work, that's why it's commented out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description : Dockerize openpilot to run on Dockerized Carla
Dockerfile.openpilot : nvidia/opengl can be stripped down
Hacky changes in the following files : selfdrive/camerad/main.cc, selfdrive/controls/controlsd.py, selfdrive/manager.py, selfdrive/modeld/modeld, tools/sim/bridge.py,
Other changes : tools/sim/lib/keyboard_ctrl.py, tools/sim/start_carla_docker.sh