system/ui: optimizes the draw_polygon() and improving code maintainability#35366
Merged
adeebshihadeh merged 1 commit intocommaai:masterfrom May 28, 2025
Merged
Conversation
deanlee
force-pushed
the
pyui_improve_draw_polygon
branch
from
ce0ad50 to
185a47c
Compare
deanlee
force-pushed
the
pyui_improve_draw_polygon
branch
from
185a47c to
7974b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ShaderState.__init__, removingrl.ffi.new()from thedraw_polygonto eliminate redundant allocations during polygon rendering._configure_shader_colorhelper function, enhancingdraw_polygonreadabilityrl.ShaderUniformDataTypewith constantsThese optimizations eliminate per-draw memory allocations, minimizing garbage collection overhead and enhancing frame rate consistency for high-frequency polygon rendering.