Improvement Implemented: Remove Obsolete Parameter Migration Function#36592
Closed
tomwolfe wants to merge 4 commits intocommaai:masterfrom
tomwolfe:pr13-branch
Closed
Improvement Implemented: Remove Obsolete Parameter Migration Function#36592tomwolfe wants to merge 4 commits intocommaai:masterfrom tomwolfe:pr13-branch
tomwolfe wants to merge 4 commits intocommaai:masterfrom
tomwolfe:pr13-branch
Conversation
added 4 commits
November 6, 2025 18:21
- Remove migrate_cached_vehicle_params_if_needed function that was marked for removal after version 0.9.9 - Remove the function call from main() - This function was used for migrating from LiveParameters to LiveParametersV2 - Since current versions are much newer than 0.9.9, this migration code is obsolete - No functional changes to active parameter learning logic
- Remove migrate_cached_vehicle_params_if_needed function that was marked for removal after version 0.9.9 - Remove the function call from main() - Remove obsolete tests that depended on the migration function - The migration functionality was for transitioning from LiveParameters to LiveParametersV2 which is no longer needed in current versions
- Fix VehicleParamsLearner test to check STEER_RATIO index instead of index 0 - Remove unused imports and fix linting issues in test_paramsd_cleanup.py, generate_long_mpc.py, run_long_mpc_generation.py - Replace banned unittest.mock import with inline Mock class - Add newlines at end of files - Make files with shebangs executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Made:
Safety/Stability Impact:
Verification:
PR Details:
This change aligns with the project's goals of maintaining a clean, safe codebase by removing obsolete functionality that's no longer needed in current and future releases.