UnifiedLabel: move scrolling text rendering to _render_scrolling_text#36722
Closed
deanlee wants to merge 1 commit intocommaai:masterfrom
Closed
UnifiedLabel: move scrolling text rendering to _render_scrolling_text#36722deanlee wants to merge 1 commit intocommaai:masterfrom
deanlee wants to merge 1 commit intocommaai:masterfrom
Conversation
Contributor
4e9e2a7 to
baaadce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



























Splits out scrolling text logic from
_renderinto a dedicated_render_scrolling_texthelper for clarity and maintainability. No behavior changes.