New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock Max Request 2NM #505

Closed
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@TK211X
Copy link

TK211X commented Jan 17, 2019

Unknown if decision was made on purpose to limit capability. Stock OEM LKAS module can and will request max 2NM.

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 17, 2019

255 is ok, but this needs panda changes as well.

@TK211X

This comment has been minimized.

Copy link
Author

TK211X commented Jan 17, 2019

Yea, drove with Chffr before I got EON. Remember trying to get the highest LKAS steering torque request. Drove into corners with system active. Was successful. Got data.

@TK211X

This comment has been minimized.

Copy link
Author

TK211X commented Jan 17, 2019

Made edit to safety_hyundai.h - How's that?

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 17, 2019

Almost :) Need to make a PR for panda repo and you also need to change the file test_hyunday.py accordingly so panda safety tests won't fail after the change.

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 29, 2019

Made proper changes in panda and in internal branch. This change will be in 0.5.9.
Thanks.

@rbiasini rbiasini closed this Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment