CI: Fix packaging by using hatch build instead of uv build#786
Merged
Conversation
amotl
changed the title
hatch instead of uv
amotl
force-pushed
the
fix-packaging
branch
2 times, most recently
from
7967b7e to
66155df
Compare
amotl
changed the title
hatch instead of uvhatch instead of uv
amotl
changed the title
hatch instead of uvhatch instead of uv
amotl
changed the title
hatch instead of uvhatch build instead of uv build
While earlier releases of Python might be EOL, it is certainly running on many systems where people can't upgrade. Why leave them behind when it's not strictly needed?
- Using `uv build` creates a wheel package without any code. - Use Twine for validating the package.
amotl
force-pushed
the
fix-packaging
branch
2 times, most recently
from
9d1b1cc to
417e3ff
Compare
mfussenegger
reviewed
Mar 4, 2026
| dynamic = ["version"] | ||
| description = "CrateDB Python Client" | ||
| authors = [{ name = "Crate.io", email = "office@crate.io" }] | ||
| requires-python = ">=3.10" |
Member
There was a problem hiding this comment.
This is needed to ensure python -m pip install crate picks up a crate-python version that actually works under the given python version.
We can't just remove this.
Member
Author
There was a problem hiding this comment.
Sorry. If it's absolutely required it will be brought back.
Member
|
Sorry to nitpick further here, but I'm a bit confused about:
Isn't this an indication that there's something wrong with the pyproject.toml definition? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Just maintenance.
Details