Rename Sports & Outdoors to Active and swap category art for line icons - #111
Open
AndrewG828 wants to merge 1 commit into
Open
Rename Sports & Outdoors to Active and swap category art for line icons#111AndrewG828 wants to merge 1 commit into
AndrewG828 wants to merge 1 commit into
Conversation
Replaces the raster category illustrations with single-scale SVG line icons and reworks the category taxonomy in `Constants.filters`, which is the one place categories are declared: - "Sports & Outdoors" becomes "Active", with a matching `Active` imageset. Category artwork is looked up as `Image(filter.title)`, so the imageset had to be renamed in lockstep. - "Household" and "Other" gain colors. A nil color is what hides a category from the Home row and the browse grid, so both are now browsable; Household needed a new imageset. - `FilterView` derives its chips from `Constants.filters` instead of keeping a parallel hardcoded list that had already drifted (it was still offering "Sports & Outdoors" and omitting "Household"). The tinted circle behind each category icon is gone — the new line icons carry their own shape — so `CircularFilterButton` renders the artwork directly at 72pt. Filter and condition chips now cross-fade on selection instead of swapping in an "x" glyph that shifted the chip's width mid-tap. Also drops `sfsfs.swift`, an empty file that was never in the build phase. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 3, 2026
JiwonJeong414
requested changes
Sep 3, 2026
|
|
||
|
|
||
| // Active range between the two handles. | ||
| let lowX = position(for: lowValue) + handleDiameter / 2 |
| private var categories : [String] = ["Clothing", "Books", "School", "Electronics", "Handmade", "Sports & Outdoors", "Other"] | ||
| /// Browsable categories, in `Constants.filters` order. A `nil` color marks a | ||
| /// pseudo-category (e.g. "Recent") that is not a real listing category. | ||
| private let categories: [String] = Constants.filters.compactMap { $0.color == nil ? nil : $0.title } |
There was a problem hiding this comment.
I like this but remove the comments
| .font(.custom("Rubik-Medium", size: 14)) | ||
| .foregroundStyle(Color.black) | ||
| } | ||
| let isSelected = filtersVM.categoryFilters.contains(category) |
| .foregroundStyle(Color.black) | ||
| } | ||
| let isSelected = filtersVM.conditionFilters.contains(condition) | ||
| Text(condition) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the raster category illustrations with single-scale SVG line icons
and reworks the category taxonomy in
Constants.filters, which is the oneplace categories are declared:
Activeimageset.Category artwork is looked up as
Image(filter.title), so the imageset hadto be renamed in lockstep.
from the Home row and the browse grid, so both are now browsable; Household
needed a new imageset.
FilterViewderives its chips fromConstants.filtersinstead of keeping aparallel hardcoded list that had already drifted (it was still offering
"Sports & Outdoors" and omitting "Household").
The tinted circle behind each category icon is gone — the new line icons carry
their own shape — so
CircularFilterButtonrenders the artwork directly at72pt. Filter and condition chips now cross-fade on selection instead of
swapping in an "x" glyph that shifted the chip's width mid-tap.
Also drops
sfsfs.swift, an empty file that was never in the build phase.Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W