Skip to content

Redesign listing cards around the image's real aspect ratio - #113

Open
AndrewG828 wants to merge 1 commit into
user/andrewgao/feature/UI-UX-Lucid-Refactor-02-chrome-primitivesfrom
user/andrewgao/feature/UI-UX-Lucid-Refactor-03-listing-cards
Open

Redesign listing cards around the image's real aspect ratio#113
AndrewG828 wants to merge 1 commit into
user/andrewgao/feature/UI-UX-Lucid-Refactor-02-chrome-primitivesfrom
user/andrewgao/feature/UI-UX-Lucid-Refactor-03-listing-cards

Conversation

@AndrewG828

@AndrewG828 AndrewG828 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Stacked PR 3 of 15. Based on #112 — merge in order.
#111#112#113#114#115#116#117#118#119#120#121#122#123#124#125

Feed cells were locked to a 4:3 box, so tall and square photos were cropped to
whatever fit. CachedImageView now reports the decoded image's aspect ratio
back to its caller, and ProductGalleryCell sizes the image from it — falling
back to 4:3 only while loading. Cells are wider (46pt of chrome instead of 68)
and the column gap tightened to match.

The cell also gains the information the old one dropped: category and condition
under the title, and a bookmark toggle that saves without opening the listing.

loadSavedState() only asks the server about a single post while
HomeViewModel.savedItems hasn't loaded yet. savedItems holds every saved
post, so once it has arrived, absence is a real answer — the naive version fired
one /post/isSaved request per visible cell on every scroll. That needed
hasLoadedSavedItems on HomeViewModel to distinguish "not saved" from
"not known yet".

CategoriesView is extracted as its own component: the Shop By Category row is
about to be used by Explore, and it is the same row Home already shows.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W

Feed cells were locked to a 4:3 box, so tall and square photos were cropped to
whatever fit. `CachedImageView` now reports the decoded image's aspect ratio
back to its caller, and `ProductGalleryCell` sizes the image from it — falling
back to 4:3 only while loading. Cells are wider (46pt of chrome instead of 68)
and the column gap tightened to match.

The cell also gains the information the old one dropped: category and condition
under the title, and a bookmark toggle that saves without opening the listing.

`loadSavedState()` only asks the server about a single post while
`HomeViewModel.savedItems` hasn't loaded yet. `savedItems` holds every saved
post, so once it has arrived, absence is a real answer — the naive version fired
one `/post/isSaved` request per visible cell on every scroll. That needed
`hasLoadedSavedItems` on `HomeViewModel` to distinguish "not saved" from
"not known yet".

`CategoriesView` is extracted as its own component: the Shop By Category row is
about to be used by Explore, and it is the same row Home already shows.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 8bce15d3-ec8e-486b-aaa9-f98f10ab1ce9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant