Skip to content

Show reviews on your own profile and rework the seller header - #124

Open
AndrewG828 wants to merge 1 commit into
user/andrewgao/feature/UI-UX-Lucid-Refactor-13-product-detailsfrom
user/andrewgao/feature/UI-UX-Lucid-Refactor-14-profile-reviews
Open

Show reviews on your own profile and rework the seller header#124
AndrewG828 wants to merge 1 commit into
user/andrewgao/feature/UI-UX-Lucid-Refactor-13-product-detailsfrom
user/andrewgao/feature/UI-UX-Lucid-Refactor-14-profile-reviews

Conversation

@AndrewG828

@AndrewG828 AndrewG828 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Stacked PR 14 of 15. Based on #123 — merge in order.
#111#112#113#114#115#116#117#118#119#120#121#122#123#124#125

Your profile's third tab was Requests, which duplicated a list you can already
reach and had nothing to do with the other two. It becomes Reviews, backed by
the same getUserReviewsBySeller call the seller profile uses, so you can see
what buyers said about you without visiting your own page as a stranger.

Tabs now carry labels and counts rather than bare icons — three unlabelled
glyphs gave no clue what the third one was — and the count comes from the loaded
data, so an empty tab reads as "Archive (0)" instead of looking broken.

On the seller profile the header, tab bar and content become one scroll view
with the tab bar pinned, replacing three nested scroll views that each scrolled
independently. Follow moves up next to the rating where the decision is being
made, instead of a full-width bar below the metrics.

Two fixes:

  • The toolbar showed the handle while the header (which already shows the name)
    was on screen, and literal placeholder copy — "For example, nothing" — once it
    scrolled away. Inverted: the toolbar names the profile only when the header
    carrying that name is gone.
  • loadExternalUser refetched on every appear, including returning from a push.
    It now tracks the loaded and in-flight user ids and skips redundant loads,
    with forceRefresh for callers that mean it.

customToolbar is removed along with the header it drew.

Note for whoever picks up Requests: with the tab gone and Home no longer pushing
SearchView, there is no way left to reach NewRequestView. The feature isn't
deleted, just unreachable — it needs a home in the new navigation.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W

Your profile's third tab was Requests, which duplicated a list you can already
reach and had nothing to do with the other two. It becomes Reviews, backed by
the same `getUserReviewsBySeller` call the seller profile uses, so you can see
what buyers said about you without visiting your own page as a stranger.

Tabs now carry labels and counts rather than bare icons — three unlabelled
glyphs gave no clue what the third one was — and the count comes from the loaded
data, so an empty tab reads as "Archive (0)" instead of looking broken.

On the seller profile the header, tab bar and content become one scroll view
with the tab bar pinned, replacing three nested scroll views that each scrolled
independently. Follow moves up next to the rating where the decision is being
made, instead of a full-width bar below the metrics.

Two fixes:

- The toolbar showed the handle while the header (which already shows the name)
  was on screen, and literal placeholder copy — "For example, nothing" — once it
  scrolled away. Inverted: the toolbar names the profile only when the header
  carrying that name is gone.
- `loadExternalUser` refetched on every appear, including returning from a push.
  It now tracks the loaded and in-flight user ids and skips redundant loads,
  with `forceRefresh` for callers that mean it.

`customToolbar` is removed along with the header it drew.

Note for whoever picks up Requests: with the tab gone and Home no longer pushing
`SearchView`, there is no way left to reach `NewRequestView`. The feature isn't
deleted, just unreachable — it needs a home in the new navigation.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 79b2a453-5cb3-48a4-b4dd-b16e234ef0ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant