Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 23, 2025

Adds documentation for the LCP problem and solver selection.

  • Adds background docs under docs/background/lcp covering the problem statement, pivoting, projection, Newton, and other methods plus a selection guide.
  • Adds dart/math/lcp/README.md documenting the lcp API layout.
  • Refreshes docs/dev_tasks/README.md and docs/onboarding/constraints.md to point to the new docs.

Before creating a pull request

  • Run `pixi run test-all` to lint, build, and test your changes (docs-only change)
  • Add unit tests for new functionality (docs-only change)
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable (not applicable)

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 23, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 23, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

#if !defined(DART_LCPSOLVER_SUPPRESS_DEPRECATED_HEADER_WARNING)
#if defined(_MSC_VER)
#pragma message( \
__FILE__ " is deprecated; include dart/math/lcp equivalents instead")
#else

P2 Badge Deprecated lcpsolver headers no longer expose old namespace

DeprecatedNamespace.hpp used to provide a deprecated dart::lcpsolver alias to keep pre-existing includes building; now it only emits a warning and ends, so code including dart/lcpsolver/dantzig/lcp.h can no longer refer to dart::lcpsolver::* and will fail to compile. If compatibility for the deprecated namespace is still required, the alias needs to be restored or callers will break immediately after this change.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 40 to 43
namespace dart::math {

/// \brief
int DART_API Lemke(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore dart::math::lcp namespace compatibility

The LCP headers now declare Lemke directly in dart::math and removed the former dart::math::lcp namespace/using alias. Any downstream code that still calls the documented legacy APIs via dart::math::lcp::Lemke/SolveLCP will now fail to compile even though the header path is unchanged. This is a breaking API change disguised as a refactor; if backward compatibility is intended, the lcp namespace alias needs to remain or a compatibility wrapper added.

Useful? React with 👍 / 👎.

@jslee02 jslee02 changed the title Add LCP documentation and refactor solver architecture Add LCP documentation Nov 23, 2025
@jslee02 jslee02 merged commit 07d573a into main Nov 23, 2025
2 checks passed
@jslee02 jslee02 deleted the lcp/doc branch November 23, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants