Backports from compact block related Bitcoin PRs#1911
Merged
UdjinM6 merged 14 commits intodashpay:developfrom Feb 9, 2018
Merged
Backports from compact block related Bitcoin PRs#1911UdjinM6 merged 14 commits intodashpay:developfrom
UdjinM6 merged 14 commits intodashpay:developfrom
Conversation
Also de-duplicates code that has been moved to mininode
If node 0 is sufficiently fast to announce its block to node 1, node 1 might already have the block by the time the node_sync_via_rpc loop gets around to node 1, resulting in the submitblock result "duplicate-inconclusive" as node 1 has the block, but prefers an alternate chain.
ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parts from bitcoin#8068:
cbda71c: Move context-required checks from CheckBlockHeader to Contextual...
Parts from bitcoin#8418:
56c87e9: Allow changing BIP9 parameters on regtest
a8689fd: Tests: refactor compact size serialization in mininode
Parts from bitcoin#8882:
b55d941: [qa] Fix race condition in sendheaders.py
Parts from bitcoin#9375:
8017547: Make CBlockIndex*es in net_processing const
8baaba6: [qa] Avoid race in preciousblock test.
180586f: Call AcceptBlock with the block's shared_ptr instead of CBlock&
6987219: Add a CValidationInterface::NewPoWValidBlock callback
0df777d: Use a temp pindex to avoid a const_cast in ProcessNewBlockHeaders
Full PR: bitcoin#8446
Full PR: bitcoin#9765
56c87e9 and 6987219 are currently not used in Dash but might become useful in the future.