Skip to content

[PECO-1042] Add http proxy support#174

Closed
nithinkdb wants to merge 19 commits intomainfrom
PECO-1042
Closed

[PECO-1042] Add http proxy support#174
nithinkdb wants to merge 19 commits intomainfrom
PECO-1042

Conversation

@nithinkdb
Copy link
Copy Markdown
Contributor

@nithinkdb nithinkdb commented Sep 11, 2023 •
edited by kravets-levko
Loading

  • Proxy support for Thrift operations
  • Proxy support for auth providers (specifically, OAuth)
  • Proxy support for Cloud Fetch
  • Proxy support for staging ingestion
  • Tests

Installable previev available in PECO-1042-build branch (npm install git@github.com:databricks/databricks-sql-nodejs.git#PECO-1042-build)

@nithinkdb nithinkdb changed the title Added patch [PECO-1042] Patch the thrift library to allow for proxies to be passed to the http agent Sep 11, 2023
@kravets-levko kravets-levko marked this pull request as draft September 11, 2023 06:19
@kravets-levko
Create own custom HTTP transport class instead of patching thrift l…
e0966de 
…ibrary

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@databricks databricks deleted a comment from github-actions Bot Sep 12, 2023
@databricks databricks deleted a comment from github-actions Bot Sep 12, 2023
@databricks databricks deleted a comment from github-actions Bot Sep 12, 2023
@databricks databricks deleted a comment from github-actions Bot Sep 12, 2023
@kravets-levko
Revert changes to thrift patch as we implement them separately
45bbe02 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@databricks databricks deleted a comment from github-actions Bot Sep 12, 2023
@kravets-levko
Fix timeouts tests
6683134 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko
Adjust HttpConnection options to work with new implementation
6c20cee 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 12, 2023 14:22 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions Bot Sep 12, 2023
@kravets-levko kravets-levko changed the title [PECO-1042] Patch the thrift library to allow for proxies to be passed to the http agent [PECO-1042] Add http proxy support Sep 12, 2023
@kravets-levko
Update unit tests
d4b2b2c 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 13, 2023 10:28 — with GitHub Actions Inactive
@kravets-levko
Structured proxy options
dfbf737 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko
Fix timeout error
b6b134d 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 14, 2023 16:00 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions Bot Sep 14, 2023
@databricks databricks deleted a comment from codecov-commenter Sep 14, 2023
@databricks databricks deleted a comment from github-actions Bot Sep 14, 2023
@kravets-levko
Refactor HttpConnection to make its usage in DBSQLCLient easier
b20dbc5 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko
Add proxy support to OAuth provider
c1b1ae9 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 15, 2023 14:15 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions Bot Sep 15, 2023
@kravets-levko
Update changelog (draft)
ce210f1 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 15, 2023 17:20 — with GitHub Actions Inactive
@kravets-levko kravets-levko temporarily deployed to azure-prod September 15, 2023 17:22 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions Bot Sep 15, 2023
@databricks databricks deleted a comment from github-actions Bot Sep 15, 2023
This was referenced Sep 25, 2023
Merged
Merged
@kravets-levko kravets-levko temporarily deployed to azure-prod October 2, 2023 08:23 — with GitHub Actions Inactive
@kravets-levko
Fix tests
112e3e4 
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod October 2, 2023 08:27 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions Bot Oct 2, 2023
@databricks databricks deleted a comment from github-actions Bot Oct 2, 2023
@kravets-levko kravets-levko temporarily deployed to azure-prod October 2, 2023 09:30 — with GitHub Actions Inactive
@kravets-levko kravets-levko mentioned this pull request Oct 2, 2023
Merged
@kravets-levko kravets-levko temporarily deployed to azure-prod October 2, 2023 13:05 — with GitHub Actions Inactive
@kravets-levko
Copy link
Copy Markdown
Contributor

kravets-levko commented Oct 3, 2023

Replaced with #193

@kravets-levko kravets-levko deleted the PECO-1042 branch February 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arikfr arikfr Awaiting requested review from arikfr

@superdupershant superdupershant Awaiting requested review from superdupershant

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db

@kravets-levko kravets-levko Awaiting requested review from kravets-levko

@susodapop susodapop Awaiting requested review from susodapop

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nithinkdb @kravets-levko