Refine auth credentials refresh flow#187
Merged
kravets-levko merged 1 commit intomainfrom Oct 2, 2023
Merged
Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
requested review from
andrefurlan-db,
arikfr,
nithinkdb,
superdupershant,
susodapop and
yunbodeng-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
nithinkdb
approved these changes
Sep 29, 2023
Contributor
nithinkdb
left a comment
nithinkdb
left a comment
There was a problem hiding this comment.
LGTM. Didn't go too in depth though, so would be good to get someone else's signoff as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our auth providers (currently OAuth) support automatic credentials update (when token expires it can request a new one). And before each request to server we should request credentials from auth provider and pass it with the request. While we were using a
HttpConnectionfromthriftlibrary it was hard to implement the desired behavior becauseHttpConnectiondidn't support updating its options. So we were re-creating it when auth credentials change, which was a bit ugly (even if it worked).But with our new custom
HttpConnectionclass added in #183 it became possible to just update headers, without recreating connection or Thrift client objects, and without doing any dirty-checks or whatever. The amount of changes probably looks too large, but it fixes the whole flow and makes it working in a straightforward wayThis PR is also a spin-off of #174