Implement custom HTTP client for thrift#183
Merged
kravets-levko merged 3 commits intomainfrom Sep 28, 2023
Merged
Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
requested review from
andrefurlan-db,
arikfr,
nithinkdb,
superdupershant,
susodapop and
yunbodeng-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
force-pushed
the
custom-thrift-http-client
branch
from
9f76b92 to
dd90d01
Compare
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
nithinkdb
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to implements some features (like better error handling) or fix weird behavior (errors not being associated with requests) we were patching the
thriftlibrary. This was really hacky way to achieve our goals, but while patch was small and everything worked we kept this solution. However, for #174 we needed to patchthrifttoo much, so we ended up creating custom HTTP client taking the one fromthriftas an example, but adjusting it for our needs. Of course, it's still a bit hacky, but a way less than it was before. And as the new HTTP client belongs to our code, we no longer need to patch thethriftlibrary