Report how many keys need to be populated#274
Merged
dimitri-yatsenko merged 4 commits intodatajoint:masterfrom Dec 20, 2016
Merged
Report how many keys need to be populated#274dimitri-yatsenko merged 4 commits intodatajoint:masterfrom
dimitri-yatsenko merged 4 commits intodatajoint:masterfrom
Conversation
dimitri-yatsenko
requested changes
Dec 20, 2016
datajoint/autopopulate.py
Outdated
| keys = list(keys) | ||
| random.shuffle(keys) | ||
|
|
||
| logger.info('Found %d keys to populate' % len(todo)) |
Member
There was a problem hiding this comment.
len(todo) is an extra query, which may take some time. Would you extract the length from keys instead? This will require converting the iterator into a list, but it's a small cost compared to an extra query.
dimitri-yatsenko
approved these changes
Dec 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike in Matlab,
populatedoes not report how many keys still have to be populated at the beginning of thepopulateinvocation. This information is a useful quick indicator.