Issue 3687

[mikepetrak]

Type of Change

• Bug fix (non-breaking change, fixes #)
• New feature (non-breaking change, adds functionality)
• Breaking change (effects multiple commands or functionality)
• Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
• Nunit test is included
• Documentation
• Build system

Purpose

Allow searching in TextHeader.
Fix IncludeSystemObjects code branch issue.
Update old-style join.

Approach

Commands to test

Screenshots

Learning

[mikepetrak]

@wsmelton , 1 test failed but it doesn't look related to my changes - any thoughts here? Thanks. :

Describe : InModule.Commands Integration Tests
Context : duplicate commands are not added
Name : It only indexes one instance per command
Result : Failed
Message : Expected $null, but got @('New-DbaDbDataGeneratorConfig', 'Invoke-DbaDbDataGenerator', 'Get-DbaRandomizedValue', 'Get-DbaRandomizedDatasetTemplate', 'Get-DbaRandomizedDataset', 'Get-DbaRandomizedType').
1 tests failed.

[wsmelton]

That would be @potatoqualitee needs to update the manifest for some new commands that were added recently it seems.

[wsmelton]

You can ignore that test when it fails, it is something we maintain (myself and/or Chrissy).

[potatoqualitee]

my bad, lemme merge fixed dev and see the passes 💯

[potatoqualitee]

all tests pass! 🍌 💃 thanks so much

[mikepetrak]

You're welcome. Thanks for the help, @wsmelton and @potatoqualitee !