Skip to content

Use DatabaseScriptPath from DacOption object#8489

Merged
potatoqualitee merged 2 commits intodataplat:developmentfrom
nvarscar:feature/dacoption-path
Aug 16, 2022
Merged

Use DatabaseScriptPath from DacOption object#8489
potatoqualitee merged 2 commits intodataplat:developmentfrom
nvarscar:feature/dacoption-path

Conversation

@nvarscar
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes Publish-DbaDacPackage not respecting DatabaseScriptPath property when provided within -DacOption #8475 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Fixing DacOption handling when the values are provided inside the options object

Approach

Extra checks for the provided values.

@potatoqualitee
Copy link
Member

Thank you so much! 🤗

@potatoqualitee
Copy link
Member

omg im going to kill codecov. thanks for the PR! going to merge 🙏🏼

@potatoqualitee potatoqualitee merged commit db59b3c into dataplat:development Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish-DbaDacPackage not respecting DatabaseScriptPath property when provided within -DacOption

2 participants

Comments