Updated XRM.Navigation.navigateTo to be up to date - #192
Merged
Conversation
Changed object PageInput to individual objects EntityList, EntityRecord, WebResource.
- added pageinput interface - added interface extensions - updated attributes
|
Could you please confirm when this pull request will be merged |
Collaborator
|
I am back from vacation next week, will look at this PR then |
magesoe
requested changes
Jul 31, 2020
magesoe
left a comment
magesoe
left a comment
Collaborator
There was a problem hiding this comment.
Love the PR, some minor changes. Do you agree with them?
| * @param navigationOptions Options for navigating to a page: whether to open inline or in a dialog. If you don't specify this parameter, page is opened inline by default. | ||
| */ | ||
| navigateTo(pageInput: PageInput, navigationOptions: NavigationOptions): Promise<undefined>; | ||
| navigateTo(pageInput: EntityRecord | EntityList | WebResource, navigationOptions: NavigationOptions): Promise<undefined>; |
Collaborator
There was a problem hiding this comment.
According to the documentation, navigationOptions is optional, so it should be navigationOptions?
- removed type PageType - removed pageinput interface - added pageType variable to each individual interface - changed navigationOptions to be optional
magesoe
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182