Skip to content

feat: add remove_recovery_codes user management method - #1643

Merged
dorsha merged 1 commit into
mainfrom
feat/mgmt-remove-recovery-codes
Aug 7, 2026
Merged

feat: add remove_recovery_codes user management method#1643
dorsha merged 1 commit into
mainfrom
feat/mgmt-remove-recovery-codes

Conversation

@dorsha

@dorsha dorsha commented Aug 6, 2026

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/17502

Related PRs

Related PRs

In a Nutshell

  • Add remove_recovery_codes user management method (sync + async)

Description

Adds the SDK wrapper for the new backend endpoint POST /v1/mgmt/user/recovery-codes/delete (descope/backend#2092), which revokes all of a user's recovery codes. Mirrors the existing remove_totp_seed method.

Must

  • Tests

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

The selection aims to cover different parts of the change by choosing reviewers who have contributed across various relevant files, ensuring a comprehensive review of both implementation and testing.

Reviewer Reason
LioriE LioriE has contributed across multiple relevant files including common.py, user.py, and user_async.py, indicating a good broad understanding of the user management functionalities.
asafshen asafshen has worked extensively on user.py, user_async.py, and the test suite, making them well-equipped to review both the implementation and its tests.
aviadl aviadl's contributions to user.py and the test suite suggest familiarity with the user management logic and testing practices.
omercnet omercnet has contributed across several files including common.py and user.py, offering a good perspective on different parts of the codebase.
ruvenzx ruvenzx has contributed to user.py and the test suite, which will be valuable for reviewing the implementation details.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds remove_recovery_codes (sync + async) wrapping POST /v1/mgmt/user/recovery-codes/delete, plus the path constant, a test, and README docs.

Sniffed out 0 issues — nothing actionable survived verification.

Sync/async parity, the {"loginId": ...} body shape, -> None signature, and the test structure all mirror remove_totp_seed exactly, and no other call sites need the same change. Good bones! Woof!


Declared coverage: FULL — 5/5 changed files reviewed.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Coverage report

The coverage rate went from 98.26% to 98.27% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/user_async.py

100% of new lines are covered (98.6% of the complete file).

descope/management/user.py

100% of new lines are covered (98.6% of the complete file).

descope/management/common.py

100% of new lines are covered (99.78% of the complete file).

@dorsha
dorsha merged commit 8531622 into main Aug 7, 2026
38 checks passed
@dorsha
dorsha deleted the feat/mgmt-remove-recovery-codes branch August 7, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants