feat: add remove_recovery_codes user management method - #1643
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe selection aims to cover different parts of the change by choosing reviewers who have contributed across various relevant files, ensuring a comprehensive review of both implementation and testing.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
Adds remove_recovery_codes (sync + async) wrapping POST /v1/mgmt/user/recovery-codes/delete, plus the path constant, a test, and README docs.
Sniffed out 0 issues — nothing actionable survived verification.
Sync/async parity, the {"loginId": ...} body shape, -> None signature, and the test structure all mirror remove_totp_seed exactly, and no other call sites need the same change. Good bones! Woof!
Declared coverage: FULL — 5/5 changed files reviewed.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/user_async.py
descope/management/user.py
descope/management/common.py
|
Related Issues
Required for:
https://github.com/descope/etc/issues/17502
Related PRs
Related PRs
In a Nutshell
remove_recovery_codesuser management method (sync + async)Description
Adds the SDK wrapper for the new backend endpoint
POST /v1/mgmt/user/recovery-codes/delete(descope/backend#2092), which revokes all of a user's recovery codes. Mirrors the existingremove_totp_seedmethod.Must
🤖 Generated with Claude Code