docs: remove_recovery_codes accepts login ID or user ID - #1649
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment strategically includes contributors with diverse yet relevant areas of expertise—covering code, asynchronous functions, and documentation—to ensure comprehensive review coverage across the impacted files.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
Docstring/README-only follow-up documenting that remove_recovery_codes accepts a login ID or a user ID. Sync and async docstrings stay in sync — good bones!
Sniffed out 1 issue:
- 1 🟡 MEDIUM: docs promise user-ID support, but the request body still serializes to
loginIdwhile the PR description says the public field isidentifier
See inline comment for details. Woof!
Declared coverage: FULL — 3/3 changed files reviewed.
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
Related Issues
Required for:
https://github.com/descope/etc/issues/17502
Related PRs
Related PRs
In a Nutshell
remove_recovery_codesaccepts a login ID or user IDDescription
Follow-up to #1643: the backend resolves the identifier as either a login ID or a user ID (descope/backend#2092), and the public API field is named
identifierlike the other user endpoints. Docstring/README update only — thelogin_idkeyword argument is kept for backward compatibility, matching the SDK's convention for dual-ID endpoints (delete,update).Must
🤖 Generated with Claude Code