Skip to content

docs: remove_recovery_codes accepts login ID or user ID - #1649

Merged
dorsha merged 1 commit into
mainfrom
feat/remove-recovery-codes-user-id
Aug 7, 2026
Merged

docs: remove_recovery_codes accepts login ID or user ID#1649
dorsha merged 1 commit into
mainfrom
feat/remove-recovery-codes-user-id

Conversation

@dorsha

@dorsha dorsha commented Aug 7, 2026

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/17502

Related PRs

Related PRs

In a Nutshell

  • Document that remove_recovery_codes accepts a login ID or user ID

Description

Follow-up to #1643: the backend resolves the identifier as either a login ID or a user ID (descope/backend#2092), and the public API field is named identifier like the other user endpoints. Docstring/README update only — the login_id keyword argument is kept for backward compatibility, matching the SDK's convention for dual-ID endpoints (delete, update).

Must

  • Tests

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

The review assignment strategically includes contributors with diverse yet relevant areas of expertise—covering code, asynchronous functions, and documentation—to ensure comprehensive review coverage across the impacted files.

Reviewer Reason
asafshen asafshen has contributed to both user-related files and user_async, covering the key areas affected by the API documentation update.
LioriE LioriE has worked on both user management files, providing a broad understanding of the user API logic.
omercnet omercnet has contributed to the README and user.py, offering perspective on documentation clarity and code consistency.
ruvenzx ruvenzx's single commit on user.py indicates direct experience with user management implementation.
aviadl aviadl's focused contribution on user.py ensures detailed knowledge of the file's context.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Docstring/README-only follow-up documenting that remove_recovery_codes accepts a login ID or a user ID. Sync and async docstrings stay in sync — good bones!

Sniffed out 1 issue:

  • 1 🟡 MEDIUM: docs promise user-ID support, but the request body still serializes to loginId while the PR description says the public field is identifier

See inline comment for details. Woof!


Declared coverage: FULL — 3/3 changed files reviewed.

Comment thread descope/management/user.py
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Coverage report

The coverage rate went from 98.21% to 98.21% ➡️

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@dorsha
dorsha merged commit e91d91e into main Aug 7, 2026
38 checks passed
@dorsha
dorsha deleted the feat/remove-recovery-codes-user-id branch August 7, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant