feat(json-render): add Tabs, Link, Select to the base catalog - #182
Merged
Conversation
Additive catalog growth (catalog v1: 14 -> 17). Adds zod prop schemas + descriptions for Tabs, Link and Select, ported from hub-ui's existing inline json-render component prop shapes, so specs using them validate at both trust boundaries and render wherever a 17-aware registry is installed. Purely additive: existing specs stay valid. Renderer implementations follow in @devframes/json-render-ui.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR A of the json-render view-provider stack (plan:
plans/json-render-ui-packaging.md, PR #181).Additive catalog growth — catalog v1 goes from 14 → 17 components. Adds zod prop schemas + descriptions for
Tabs,Link, andSelect, ported from hub-ui's existing inline json-render component prop shapes, so specs using them validate at both trust boundaries (server ingress + client render) and render wherever a 17-aware registry is installed.Purely additive: existing specs stay valid; no behavior change. Renderer implementations land next in
@devframes/json-render-ui(PR B).prop-schemas.ts:TabsPropsSchema/LinkPropsSchema/SelectPropsSchema+ registered inbasePropSchemas.catalog.ts: descriptions for the three (thecomponentDescriptionstype forces completeness).index.ts: export the three schemas.catalog.test.ts: assert the 17-component set.@devframes/json-renderAPI snapshot.Verified:
typecheck(workspace, 26 pkgs),eslint,knip, json-render build + catalog tests.Created with the help of an agent.