feat(json-render-ui): implement Tabs, Link, Select renderers - #183
Merged
Conversation
Base automatically changed from
feat/json-render-catalog-tabs-link-select
to
main
August 10, 2026 04:23
Implements the three catalog components added in the previous commit, so the reference Vue renderer covers all seventeen. Link is a thin anchor (safe-scheme only) with a runtime Icon; Select wraps @antfu/design FormSelect (or FormCombobox when searchable); Tabs is a thin custom component (dynamic tab icons need the runtime Icon, which @antfu/design LayoutTabs' class-based icon can't do) with a stateful inner component so uncontrolled selection persists and a $bindState binding writes back to the state store. Registered in baseRegistry (now 17) and exported from ./components.
antfu
force-pushed
the
feat/json-render-ui-provider
branch
from
August 10, 2026 04:23
f75d5dc to
84c0424
Compare
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR B of the json-render view-provider stack (plan:
plans/json-render-ui-packaging.md). Stacked on #182.Implements the three catalog components #182 added, so the reference Vue renderer covers all 17:
http(s)/mailto:), with a runtimeIcon.@antfu/designFormSelect(orFormComboboxwhensearchable). Icon/description on options are accepted by the catalog but not rendered by the reference select (documented).Icon, whichLayoutTabs' class-based icon can't do. Uses a stateful inner component so uncontrolled selection persists across renders (aJrComponentrender fn can't hold aref), and writes back to the state store whenvalueis$bindState-bound. Roving tabindex + arrow-key nav.Registered in
baseRegistry(17) and exported from./components. API snapshots updated.Verified:
typecheck,eslint, build, package tests.Created with the help of an agent.