fix(unitree): marshal stop_movement zero-twist onto the loop thread#2977
Merged
Conversation
ruthwikdasyam
requested review from
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 15, 2026 17:47
Contributor
Greptile SummaryThis PR moves the Unitree stop command onto the connection event loop.
Confidence Score: 5/5The event-loop-thread stop path can delay the zero-twist command.
dimos/robot/unitree/connection.py Important Files Changed
Reviews (1): Last reviewed commit: "fix(unitree): marshal stop_movement zero..." | Re-trigger Greptile |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
- Coverage 72.17% 71.91% -0.27%
==========================================
Files 1020 1021 +1
Lines 91664 91810 +146
Branches 8375 8414 +39
==========================================
- Hits 66163 66025 -138
- Misses 23267 23563 +296
+ Partials 2234 2222 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
paul-nechifor
approved these changes
Jul 15, 2026
Nabla7
pushed a commit
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stop_movementcalled_publish_movement(0,0,0)directly from non-loop threadsSolution
Marshal the send onto the connection's event loop via
asyncio.run_coroutine_threadsafe, matching the existing pattern inpublish_requestandmove().How to Test
Contributor License Agreement