fix(install): enforce smoke test timeout#3053
Open
jmnie wants to merge 4 commits into
Open
Conversation
jmnie
marked this pull request as ready for review
July 19, 2026 16:15
jmnie
requested review from
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 19, 2026 16:15
Contributor
Greptile SummaryThis PR adds a bounded timeout to the post-install smoke test. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/jiaming/ins..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
The post-install smoke test promises to stop after 60 seconds but launches DimOS without a timeout. Ctrl+C can also terminate the installer before it prints the successful-install quickstart.
Solution
SIGTERMat the deadline, thenSIGKILLafter a 5-second shutdown grace period so the timeout remains bounded.130, allowing the completed installer to print its quickstart.This does not depend on GNU
timeout, which is absent from stock macOS.How to Test
Direct checks on macOS with Bash 3.2:
0remains0; exit7remains7124after 1 second124after 60 seconds130in about 0.4 seconds124The complete MuJoCo smoke command was not run locally; the timeout and signal paths were exercised against real shell processes. No robot hardware was used.
AI assistance
OpenAI Codex with GPT-5 was heavily involved in repository analysis, implementation, adversarial signal testing, and PR preparation. The contributor reviewed the complete diff, understands its timeout, signal, exit-code behavior and limitations, and stands behind the submitted changes.
Checklist
uv run pytest, pre-commit) for the files I changed.