feat: extract manipulation plan execution manager - #3183
Open
TomCC7 wants to merge 22 commits into
Open
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
TomCC7
force-pushed
the
cc/feat/manip-execution
branch
from
July 25, 2026 07:53
d5c492a to
945f2c0
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3183 +/- ##
==========================================
+ Coverage 74.90% 74.95% +0.05%
==========================================
Files 1114 1115 +1
Lines 106086 105864 -222
Branches 9665 9625 -40
==========================================
- Hits 79461 79354 -107
+ Misses 23816 23719 -97
+ Partials 2809 2791 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
TomCC7
commented
Jul 25, 2026
TomCC7
commented
Jul 27, 2026
TomCC7
commented
Jul 27, 2026
TomCC7
marked this pull request as ready for review
July 27, 2026 21:15
TomCC7
requested review from
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
July 27, 2026 21:15
paul-nechifor
approved these changes
Jul 28, 2026
paul-nechifor
enabled auto-merge
July 28, 2026 02:53
TomCC7
disabled auto-merge
July 28, 2026 02:55
Member
Author
|
@mustafab0 I'll leave this pr for your review, if you think it's good to go can just enable merge |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
Manipulation execution mixed plan interpretation, per-robot trajectory splitting, coordinator task selection, dispatch, rollback, cancellation, and status polling into
ManipulationModule.That design treated a coordinated plan as independently executable robot fragments. It also duplicated trajectory-task policy above the control coordinator, even though the coordinator owns the hardware state and arbitration needed to decide whether a trajectory is safe to start.
Solution
PlanExecutionManageras the boundary between planning and control. It maps one completeGeneratedPlanfrom global planner joint names to coordinator joint names, serializes execute/cancel operations, and makes one coordinator RPC.ControlCoordinatormodule reference intoManipulationModuleand pass that framework-managed RPC proxy directly toPlanExecutionManager; no forwarding client or independently owned RPC lifecycle is needed.ManipulationModuleblueprint to include aControlCoordinator. Remove the standalonexarm6-planner-onlyanddual-xarm6-plannerblueprints in favor of their mock-capable coordinator-backed replacements.ControlCoordinatorexactly oneJointTrajectoryTask. Multi-arm coordinators configure that task with the union of their controlled joints; single-arm subset plans remain valid.UNCERTAINbecause the remote operation may have occurred.JointTrajectoryTask, including a start-state check against coordinator-owned hardware positions. Configurestart_position_tolerancethrough task parameters.attrs, while retaining Pydantic at the untyped task-parameter boundary.Breaking API and behavior changes
ManipulationModule.execute(robot_name=...)execute()ManipulationModule.execute_plan(plan, robot_name=...)execute_plan(plan)ManipulationModule.get_trajectory_status(robot_name=...)RobotModelConfig.coordinator_task_nameCoordinatorClient.execute_trajectory(task_name, trajectory) -> boolexecute_trajectory(trajectory) -> TrajectoryExecutionResultCoordinatorClient.cancel_trajectory(task_name) -> boolcancel_trajectory() -> TrajectoryCancellationResultCANCELLED,ALREADY_STOPPED,NO_TRAJECTORY_TASK, orUNCERTAIN.ManipulationModulecould run without a coordinatorControlCoordinatormodule reference is requiredxarm6-planner-onlyanddual-xarm6-plannerxarm7-planner-coordinatorfor a mock-capable single-arm planning stack ordual-xarm6-planner-coordinatorfor dual-arm planning.JointTrajectoryTaskinstances per coordinatorValueError. Multi-arm blueprints must create one task claiming all coordinated joints.JointTrajectoryTask.execute(trajectory) -> boolexecute(trajectory, current_positions) -> TrajectoryExecutionResultGenerated-plan joint names remain globally scoped as
<robot>/<local_joint>.ExecutionTargetresolves those names to coordinator joints; the caller no longer passes a robot ID during execution.How to Test
Current result: 632 passed, 12 deselected.
The suite covers whole-plan mapping, subset trajectories, multi-arm atomic dispatch, execute/cancel serialization, typed coordinator outcomes, start-state rejection, one-task enforcement, module lifecycle cleanup, and updated manipulator blueprints.
Additional validation:
AI assistance
OpenAI Codex with GPT-5 provided substantial assistance with design exploration, implementation, tests, documentation, and review-feedback changes under human direction. The author reviewed and approved the design decisions interactively.
Checklist