Collider::round_triangle doesn't have round edges no matter the border_radius

[akappel]

Hello,

I was attempting to use .insert(Collider::round_triangle(a, b, c, border_radius) in my project, but no value I provided to border_radius would cause the edges to be rounded.

My exact call was

...
.insert(Collider::round_triangle(
    Vec2::new(-128., 32.),
    Vec2::new(-128., -32.),
    Vec2::new(128., 0.),
    1000.0,
...

I ended up using Collider::round_convex_hull(...) for now, but figured I'd make a bug ticket in the meantime. I can provide further detail of necessary. Thanks!

[Aceeri]

I think roundness just isn't implemented for the debug renderer in the case of triangle/trimesh/height field:

/*
 * Round shapes.
 */
TypedShape::RoundCuboid(s) => {
    let vtx = s.to_polyline(self.style.border_subdivisions);
    backend.draw_line_strip(object, &vtx, pos, &Vector::repeat(1.0), color, true)
}
TypedShape::RoundTriangle(s) => {
    // TODO: take roundness into account.
    self.render_shape(object, backend, &s.inner_shape, pos, color)
}
// TypedShape::RoundTriMesh(s) => self.render_shape(backend, &s.inner_shape, pos, color),
// TypedShape::RoundHeightField(s) => {
//     self.render_shape(backend, &s.inner_shape, pos, color)
// }
TypedShape::RoundConvexPolygon(s) => {
    let vtx = s.to_polyline(self.style.border_subdivisions);
    backend.draw_line_strip(object, &vtx, pos, &Vector::repeat(1.0), color, true)
}

The colliders are probably actually taking it into account however.

[akappel]

Thanks @Aceeri! I figured as much. If you don't mind, where did you find this snippet of code? I can't seem to track it down. I'd like to see about fixing it if possible.

[Aceeri]

@akappel

rapier/src/pipeline/debug_render_pipeline/debug_render_pipeline.rs

Line 386 in b003247

/*