Update live with current master #9433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added spacing * fixed typo result
Updating file to target the entire class using the student tag, and rewording, ever so slightly, the usage against read/write properties (I felt this was backwards because the sample code is the read/write property, whereas the previous example was read only)
* Add a new csharp file * Remove constructor, add string interpolation * respond to feedback
#9416) * Provide guidance on how to properly release unmanaged resources for thread-unsafe APIs Provide the guidance that developers lack on how to avoid heap corruption when releasing unmanaged buffers. * remove extra spaces
* Update how-to-configure-network-tracing.md added the traceOutputOptions to log Process ID and timestamp * Update how-to-configure-network-tracing.md
* Document .NET Core resource fallback process @rpetrusha Ultimately this belongs in the .NET Guide as you mentioned. In the interim adding .NET Core doc here... This is a rough first attempt. Feel free to recommend edits... I chose some content replication rather that restructuring to make the content digestible. * PR feedback * Further PR feedback * More PR feedback
* Revised true and false operators (and literals) * Fix link * Fix link
* clarify that readonly fields can be assigned Clarify that readonly fields can be assigned multiple times, but cannot be assigned outside of initializers and constructors. Fixes #9351 * Update readonly.md
* turn off feedback and update ms.date * author changes
* Add section for Office PIA consumption sample * Address localization issue * Update docs/samples-and-tutorials/index.md Co-Authored-By: AaronRobinsonMSFT <arobins@microsoft.com>
* Update cs1626.md
Updated error description and added finally{} block to provide context for option of removing the catch block to resolve the compile error
* Update cs1626.md
* Update porting docs based on feedback * Update docs/core/porting/libraries.md Co-Authored-By: cartermp <pcarter@fastmail.com> * Update docs/core/porting/index.md Co-Authored-By: cartermp <pcarter@fastmail.com>
* Clarify the recommendations on try / catch and try / finally Also, formatting to code fence `null`. Code formatting (there were hard tabs) Finally, change header to be more explicit about restoring state when methods exit because of exceptions. * respond to feedback.
* Initial commit of new publish type info * Initial skeleton for 3.0 * Added details about JSON and MetadataLoadContext * changes to date * minor update * Finished features of 3.0 * minor acro * add toc entry * remove git merge info * Renamed file to correct style * Added missing file after rename * Changed tool-name to tool-command-name * adjusted wording for windows desktop * Fix sequencereader header for TOC * Feedback from Bill * Added MetadataLoadContext back in * update xref * fix xref 2 * fix xref 3
* Update for project level nullable setting And address feedback missed on the last PR for nullables. /cc @pkulikov * fix a typo * respond to feedback. * respond to feedback.
* revert 9416 * fix code indentation
* update windows prereqs * remove 2017 from the sentence * feedback
mairaw
requested review from
BillWagner,
cartermp,
douglaslMS,
karelz and
rpetrusha
as code owners
* remove mac text regarding package managers It was a copy/paste error from the linux instructions On a Mac, the SDKs and runtimes must be removed by removing the directories. fixes #9218 * fix tab names
BillWagner
approved these changes
Dec 6, 2018
when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.