Fix assert in UsePatternMatching.CSharpAsAndNullCheckDiagnosticAnalyzer#32440
Merged
mavasani merged 2 commits intodotnet:masterfrom Jan 15, 2019
Merged
Fix assert in UsePatternMatching.CSharpAsAndNullCheckDiagnosticAnalyzer#32440mavasani merged 2 commits intodotnet:masterfrom
mavasani merged 2 commits intodotnet:masterfrom
Conversation
1. Bail out early if there is a reference to assigned local between the declaration and null check being replaced with pattern matching. 2. Remove assert for bail out in presence of errors/unhandled cases. Fixes dotnet#31388
Contributor
Author
Contributor
Author
|
Much easier to review with https://github.com/dotnet/roslyn/pull/32440/files?w=1 |
src/Features/CSharp/Portable/UsePatternMatching/CSharpAsAndNullCheckDiagnosticAnalyzer.cs
Show resolved
Hide resolved
Contributor
Appreciated :) |
mavasani
commented
Jan 14, 2019
src/Features/CSharp/Portable/UsePatternMatching/CSharpAsAndNullCheckDiagnosticAnalyzer.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jan 14, 2019
Contributor
Author
|
@vatsalyaagrawal @jinujoseph for approval |
jinujoseph
approved these changes
Jan 14, 2019
xoofx
pushed a commit
to stark-lang/stark-roslyn
that referenced
this pull request
Apr 16, 2019
Fix assert in UsePatternMatching.CSharpAsAndNullCheckDiagnosticAnalyzer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31388