Don't throw adding references to a project with a missing reference #56951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ryzngard
approved these changes
Oct 5, 2021
Member
Can we throw when that happens? it seems... bad (and we have ample precedence for failing on otehr bogus state). |
Member
Author
Yes, unfortunately as a breaking change though and it's hard to know what might rely on it. In hindsight this would have been good to pull for 17.0 as a cleanup, but I'm not sure if we're stuck with it until next major rev. |
Member
That's fine with me. It's a broken scenario. |
The Roslyn workspace model allows you to have project references to projects that aren't in the solution. If you have such a project, and tried to add another project reference, it'd fail because while validating the new reference we'd trip up on the missing one.
jasonmalinowski
force-pushed
the
fix-mishandling-of-missing-project-reference
branch
from
d06bdd0 to
c8842c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roslyn workspace model allows you to have project references to projects that aren't in the solution. If you have such a project, and tried to add another project reference, it'd fail because while validating the new reference we'd trip up on the missing one.
This explains the exception being thrown in https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1251708, but doesn't explain how we got into this situation in the first place. That root cause is still under investigation.