Fix deadlock in case if pipe reading fails#82326
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom Feb 9, 2026
Merged
Conversation
In RemoteCallback.InvokeAsync we have a pipe being used with simultaneous reading and writing. If the reading task fails, it was possible for us to deadlock, since writing to the pipe will then block as the pipe hits it's maximum size. Changing how we wait ensures that if one task fails we'll rethrow the exception rather than deadlock. Fixes dotnet#82323
dibarbet
approved these changes
Feb 7, 2026
CyrusNajmabadi
approved these changes
Feb 7, 2026
Contributor
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Less scary than I thought this would be :-)
JoeRobich
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RemoteCallback.InvokeAsync we have a pipe being used with simultaneous reading and writing. If the reading task fails, it was possible for us to deadlock, since writing to the pipe will then block as the pipe hits it's maximum size. Changing how we wait ensures that if one task fails we'll rethrow the exception rather than deadlock.
Fixes #82323