Fix InvalidCastException in split-if refactoring for top-level statements#82807
Open
dibarbet wants to merge 2 commits intodotnet:mainfrom
Open
Fix InvalidCastException in split-if refactoring for top-level statements#82807dibarbet wants to merge 2 commits intodotnet:mainfrom
dibarbet wants to merge 2 commits intodotnet:mainfrom
Conversation
…ents root.FindNode can return a GlobalStatementSyntax instead of an IfStatementSyntax when they share the same span in top-level code. Use getInnermostNodeForTie and FirstAncestorOrSelf to locate the correct if-statement node, matching the pattern already used by AbstractMergeIfStatementsCodeRefactoringProvider. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jasonmalinowski
approved these changes
Mar 17, 2026
CyrusNajmabadi
approved these changes
Mar 18, 2026
JoeRobich
approved these changes
Mar 18, 2026
...es/Core/Portable/SplitOrMergeIfStatements/AbstractSplitIfStatementCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...es/Core/Portable/SplitOrMergeIfStatements/AbstractSplitIfStatementCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
…redundant assert Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably resolves dotnet/vscode-csharp#9066
root.FindNode can return a GlobalStatementSyntax instead of an IfStatementSyntax when they share the same span in top-level code. Use getInnermostNodeForTie and FirstAncestorOrSelf to locate the correct if-statement node, matching the pattern already used by AbstractMergeIfStatementsCodeRefactoringProvider.
Microsoft Reviewers: Open in CodeFlow