Enable Linux execution for issue #83159 Windows-only formatting tests#84415
Draft
mwiemer-microsoft wants to merge 5 commits into
Draft
Enable Linux execution for issue #83159 Windows-only formatting tests#84415mwiemer-microsoft wants to merge 5 commits into
mwiemer-microsoft wants to merge 5 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace SyntaxFactory.ElasticCarriageReturnLineFeed with SyntaxFactory.ElasticEndOfLine(Environment.NewLine) in IDE code fixes and refactorings so inserted trivia uses platform-appropriate newlines. This allows the ~73 tests marked WindowsOnly (issue #83159) to run on Linux as well. The remaining 11 tests (10 ConvertToRawString + 1 MakeFieldReadonly Theory) remain WindowsOnly because they test platform-specific CRLF content in string literals/test data. Files changed in production code: - CSharpSyntaxGeneratorInternal.cs - TypeDeclarationSyntaxExtensions.cs - CSharpCodeGenerationHelpers.cs - UseSimpleUsingStatementCodeFixProvider.cs - CSharpIsAndCastCheckCodeFixProvider.cs - CSharpUseConditionalExpressionHelpers.cs - CSharpUseCollectionInitializerCodeFixProvider_CollectionInitializer.cs - ConvertToRecordEngine.cs - CSharpConvertIfToSwitchCodeRefactoringProvider.Rewriting.cs - CSharpConvertAutoPropertyToFullPropertyCodeRefactoringProvider.cs - CSharpIntroduceVariableService_IntroduceLocal.cs - CSharpMethodExtractor.CSharpCodeGenerator.cs - DocCommentConverter.cs - ConvertPrimaryToRegularConstructorCodeRefactoringProvider.cs - UseExpressionBodyForLambdaCodeActionHelpers.cs - CSharpMetadataAsSourceService.cs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…t status Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…aths Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Remaining Windows-only tests
Microsoft Reviewers: Open in CodeFlow