Avoid assert on erroneous target-typed conditionals - #84752
Merged
Conversation
jjonescz
added
Area-Compilers
Feature - Nullable Reference Types
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a debug-build crash in C# nullable flow analysis when analyzing certain erroneous conditional (?:) expressions that remain as BoundUnconvertedConditionalOperator (e.g., target-typed conditionals that never get converted due to earlier binding errors). The fix relaxes a Debug.Assert to allow this error case without throwing, and adds a regression test to ensure the compiler reports diagnostics (instead of crashing) for the reported scenario.
Changes:
- Update a
Debug.AssertinNullableWalkerto permit unconverted conditional operators that already have errors, avoiding a debug-only failure. - Add a regression test covering the reported repro pattern and verifying expected diagnostics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs | Adjusts an assertion to tolerate erroneous unconverted conditionals during nullable analysis without crashing debug builds. |
| src/Compilers/CSharp/Test/Semantic/Semantics/ConditionalOperatorTests.cs | Adds a regression test validating diagnostics for an invalid conditional that previously triggered the debug assertion path. |
jjonescz
marked this pull request as ready for review
August 4, 2026 16:02
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
RikkiGibson
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84641.
Microsoft Reviewers: Open in CodeFlow