Replace handwritten lookup computation with shared helper - #102302
Closed
MichalStrehovsky wants to merge 1 commit into
Closed
Replace handwritten lookup computation with shared helper#102302MichalStrehovsky wants to merge 1 commit into
MichalStrehovsky wants to merge 1 commit into
Conversation
Noticed this when working on dotnet#102299. This is bypassing the `CORINFO_LOOKUP_NOT_SUPPORTED` backout logic. Didn't actually test this, I'll let CI decide if this is a good change.
ghost
added
the
Member
Author
|
Okay then, no. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when working on #102299. This is bypassing the
CORINFO_LOOKUP_NOT_SUPPORTEDbackout logic. Didn't actually test this, I'll let CI decide if this is a good change.Cc @dotnet/ilc-contrib