Do not allow generic inlining of delegate creation - #102299
Merged
Merged
Conversation
Fixes dotnet#102259. Delegate creation requires form of lookups that are hard to express across inlined generics. This was introduced when we started doing more generic inlining in dotnet#99265. I [suspected](dotnet#99265 (comment)) things might not be correct here but assumed we'd have test coverage for sure. _Now_ we have test coverage.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
May 16, 2024
Noticed this when working on dotnet#102299. This is bypassing the `CORINFO_LOOKUP_NOT_SUPPORTED` backout logic. Didn't actually test this, I'll let CI decide if this is a good change.
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
EgorBo
approved these changes
May 16, 2024
EgorBo
left a comment
EgorBo
left a comment
Member
There was a problem hiding this comment.
I presume this is NAOT specific? The test seems to be passing on CoreCLR when I run it locally
Member
CoreCLR uses a slow fallback path for the complex delegates like the one used in the repro. The slow fallback path ( NativeAOT does not want to depend on full type loader to create delegates. You can think about it as NativeAOT-specific optimizations that is not implemented in CoreCLR (yet). |
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Fixes dotnet#102259. Delegate creation requires form of lookups that are hard to express across inlined generics. This was introduced when we started doing more generic inlining in dotnet#99265. I [suspected](dotnet#99265 (comment)) things might not be correct here but assumed we'd have test coverage for sure. _Now_ we have test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102259.
Delegate creation requires form of lookups that are hard to express across inlined generics.
This was introduced when we started doing more generic inlining in #99265. I suspected things might not be correct here but assumed we'd have test coverage for sure. Now we have test coverage.
Cc @dotnet/ilc-contrib