JIT: Avoid unnecessary argument spills in indirect call transformer - #131754
Open
jakobbotsch wants to merge 2 commits into
Open
JIT: Avoid unnecessary argument spills in indirect call transformer#131754jakobbotsch wants to merge 2 commits into
jakobbotsch wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR JIT’s indirect call transformation logic to avoid spilling invariant call arguments (constants, GT_LCL_ADDR, GT_FTN_ADDR) into temporaries when splitting calls for guarded transforms. This prevents certain arguments (notably GT_LCL_ADDR) from being rewritten into GT_LCL_VAR temps, aligning with downstream shape expectations and avoiding the reported assert.
Changes:
- In
IndirectCallTransformer::Transformer::SplitCall, only spill “effectful / addr-exposed” uses when the use is notGenTree::IsInvariant().
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS This was spilling the |
AndyAyersMS
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #131665