Skip to content

Releasing 1.1.0.0#24

Merged
PlagueHO merged 38 commits intomasterfrom
dev
Sep 28, 2018
Merged

Releasing 1.1.0.0#24
PlagueHO merged 38 commits intomasterfrom
dev

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Sep 28, 2018

Pull Request (PR) description

Releasing 1.1.0.0


This change is Reviewable

PlagueHO and others added 30 commits June 16, 2018 17:10
Refactor to Remove Harness - Fixes #11
If file does not exist Test-TargetResouce will return $false
Updated tests.
So Test-TargetResource return $false if file being managed doesn't exist
Issue#13 - Update all DSC resources Test-TargetResource to return $false when file being manged does not exist.
Correct Configuration Names in Example files - Fixes #15
Add pull request template and issue templates - Fixes #17
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2018

Codecov Report

Merging #24 into master will decrease coverage by 8%.
The diff coverage is 98%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #24   +/-   ##
====================================
- Coverage      99%   91%   -9%     
====================================
  Files           3     5    +2     
  Lines         177   246   +69     
====================================
+ Hits          176   224   +48     
- Misses          1    22   +21

@johlju
Copy link
Copy Markdown
Member

johlju commented Sep 28, 2018

@johlju
Copy link
Copy Markdown
Member

johlju commented Sep 28, 2018

Either change to -OptIn @('PublishExample'), or remove -OptIn @() to always opt-in to all default deploy steps.

https://github.com/PowerShell/DscResource.Tests/blob/02fcc94f54481ff450fc39beb40809956219ad72/AppVeyor.psm1#L1261

@PlagueHO
Copy link
Copy Markdown
Member Author

@johlju - good catch! Doh! Fixed.

@PlagueHO PlagueHO merged commit 7c5f22d into master Sep 28, 2018
@johlju
Copy link
Copy Markdown
Member

johlju commented Sep 28, 2018

That didn't work out as expected. 🙂 Is it the wrong key or something else? 🤔

@PlagueHO
Copy link
Copy Markdown
Member Author

Wrong key 😁 I created a key that could only publish FileContentDsc - I needed to make a general key that could be used. But all good now!

https://ci.appveyor.com/project/PlagueHO/filecontentdsc#L1186

So they're all up on the PS Gallery now:

Install-Script -Name IniSettingsFile_SetPlainTextEntry_Config 

Great work @johlju !!!!

@PlagueHO
Copy link
Copy Markdown
Member Author

I'll begin to work on other resources soon 😁

@jcwalker
Copy link
Copy Markdown
Contributor

jcwalker commented Oct 2, 2018

@PlagueHO when is this going to make it to the PSGallery? I'm still seeing version 1.0.0.38.

@PlagueHO
Copy link
Copy Markdown
Member Author

PlagueHO commented Oct 2, 2018

@jcwalker - that is my bad. I was focusing on the new auto example feature and forgot the actual module. I'm publish today. Sorry about that.

@PlagueHO
Copy link
Copy Markdown
Member Author

PlagueHO commented Oct 2, 2018

@jcwalker - published to the PSGallery now.

@jcwalker
Copy link
Copy Markdown
Contributor

jcwalker commented Oct 2, 2018

@PlagueHO No worries and thanks for all you do!

@PlagueHO
Copy link
Copy Markdown
Member Author

PlagueHO commented Oct 3, 2018

@jcwalker - a pleasure to support the community and thanks for your help too! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants